Skip to content

[fix](arrow-flight-sql) Fix query result is empty and not return query error message#45023

Merged
xinyiZzz merged 1 commit intoapache:masterfrom
xinyiZzz:20241204_fix_metadata
Dec 5, 2024
Merged

[fix](arrow-flight-sql) Fix query result is empty and not return query error message#45023
xinyiZzz merged 1 commit intoapache:masterfrom
xinyiZzz:20241204_fix_metadata

Conversation

@xinyiZzz
Copy link
Contributor

@xinyiZzz xinyiZzz commented Dec 5, 2024 •
edited
Loading

What problem does this PR solve?

After the query failed, Doris Arrow Flight SQL returned an empty result without returning the query error message.

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

doris-robot commented Dec 5, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@xinyiZzz
Copy link
Contributor Author

xinyiZzz commented Dec 5, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Dec 5, 2024

TPC-H: Total hot run time: 40008 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1c5216528bc4c9883c3b9c34430d896e5ee93e06, data reload: false

------ Round 1 ----------------------------------
q1	17594	7386	7302	7302
q2	2069	179	169	169
q3	10541	1145	1181	1145
q4	10238	699	767	699
q5	7604	2682	2628	2628
q6	241	146	144	144
q7	1007	635	632	632
q8	9266	1832	1939	1832
q9	6594	6479	6457	6457
q10	7038	2280	2360	2280
q11	467	261	264	261
q12	409	217	224	217
q13	17779	3014	3022	3014
q14	261	208	224	208
q15	577	538	535	535
q16	674	598	571	571
q17	970	559	574	559
q18	7319	6872	6790	6790
q19	1339	1026	997	997
q20	468	176	180	176
q21	4028	3294	3075	3075
q22	376	317	319	317
Total cold run time: 106859 ms
Total hot run time: 40008 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7266	7275	7206	7206
q2	329	238	236	236
q3	2942	2790	3038	2790
q4	2131	1837	1765	1765
q5	5542	5699	5641	5641
q6	224	135	136	135
q7	2213	1753	1786	1753
q8	3412	3562	3483	3483
q9	8989	8930	9021	8930
q10	3588	3555	3575	3555
q11	602	512	507	507
q12	819	673	609	609
q13	12695	3248	3193	3193
q14	302	272	278	272
q15	553	505	530	505
q16	675	653	614	614
q17	1796	1566	1565	1565
q18	7957	7402	7437	7402
q19	1629	1504	1584	1504
q20	2043	1812	1872	1812
q21	5503	5376	5301	5301
q22	639	594	571	571
Total cold run time: 71849 ms
Total hot run time: 59349 ms

@doris-robot
Copy link

doris-robot commented Dec 5, 2024

TeamCity be ut coverage result:
Function Coverage: 38.47% (10006/26013)
Line Coverage: 29.52% (83900/284259)
Region Coverage: 28.62% (43116/150661)
Branch Coverage: 25.21% (21913/86922)
Coverage Report: http://coverage.selectdb-in.cc/coverage/1c5216528bc4c9883c3b9c34430d896e5ee93e06_1c5216528bc4c9883c3b9c34430d896e5ee93e06/report/index.html

@doris-robot
Copy link

doris-robot commented Dec 5, 2024

TPC-DS: Total hot run time: 191348 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1c5216528bc4c9883c3b9c34430d896e5ee93e06, data reload: false

query1	1206	405	394	394
query2	6526	2131	2087	2087
query3	6702	213	211	211
query4	34125	23574	23511	23511
query5	4396	474	444	444
query6	283	199	182	182
query7	4622	310	316	310
query8	296	217	218	217
query9	9804	2756	2734	2734
query10	472	259	258	258
query11	18159	15391	15278	15278
query12	153	107	107	107
query13	1667	411	417	411
query14	9053	6801	7685	6801
query15	306	182	191	182
query16	8202	485	483	483
query17	1832	578	567	567
query18	2139	300	315	300
query19	367	160	155	155
query20	122	113	113	113
query21	211	103	102	102
query22	4580	4258	4386	4258
query23	34947	34107	35021	34107
query24	11908	2529	2483	2483
query25	672	386	380	380
query26	1856	150	151	150
query27	2915	278	280	278
query28	8218	2461	2442	2442
query29	1058	396	404	396
query30	300	147	151	147
query31	1023	810	817	810
query32	96	60	60	60
query33	771	286	280	280
query34	1034	498	539	498
query35	850	763	736	736
query36	1079	929	949	929
query37	290	78	76	76
query38	4343	4259	4163	4163
query39	1481	1443	1432	1432
query40	278	101	100	100
query41	45	43	42	42
query42	106	100	96	96
query43	530	493	487	487
query44	1235	802	795	795
query45	185	165	167	165
query46	1170	708	704	704
query47	1910	1851	1846	1846
query48	396	323	320	320
query49	1273	385	401	385
query50	819	380	384	380
query51	7232	7171	7128	7128
query52	107	94	92	92
query53	253	184	176	176
query54	1118	393	394	393
query55	79	82	76	76
query56	252	238	249	238
query57	1256	1120	1102	1102
query58	218	211	218	211
query59	3234	3058	3041	3041
query60	297	241	242	241
query61	106	109	111	109
query62	857	680	686	680
query63	207	185	185	185
query64	5034	664	682	664
query65	3326	3188	3279	3188
query66	1259	307	302	302
query67	16081	15694	15659	15659
query68	4961	570	558	558
query69	419	245	262	245
query70	1267	1137	1149	1137
query71	321	253	252	252
query72	6330	4077	3988	3988
query73	771	360	356	356
query74	10393	9093	8892	8892
query75	3455	2645	2676	2645
query76	3003	1145	1055	1055
query77	515	272	279	272
query78	10242	9551	9572	9551
query79	2359	611	624	611
query80	1187	432	440	432
query81	541	234	243	234
query82	706	118	117	117
query83	245	144	148	144
query84	238	71	69	69
query85	1454	296	296	296
query86	465	306	265	265
query87	4806	4572	4628	4572
query88	3848	2224	2208	2208
query89	412	295	295	295
query90	2113	183	183	183
query91	150	103	118	103
query92	65	50	52	50
query93	1467	557	555	555
query94	875	300	295	295
query95	352	251	286	251
query96	604	279	280	279
query97	2818	2675	2676	2675
query98	216	198	199	198
query99	1559	1315	1288	1288
Total cold run time: 305084 ms
Total hot run time: 191348 ms

@doris-robot
Copy link

doris-robot commented Dec 5, 2024

ClickBench: Total hot run time: 32.81 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1c5216528bc4c9883c3b9c34430d896e5ee93e06, data reload: false

query1	0.04	0.04	0.03
query2	0.06	0.04	0.03
query3	0.23	0.07	0.08
query4	1.61	0.10	0.10
query5	0.44	0.41	0.41
query6	1.16	0.67	0.67
query7	0.02	0.01	0.01
query8	0.04	0.03	0.03
query9	0.56	0.53	0.52
query10	0.56	0.55	0.56
query11	0.15	0.11	0.11
query12	0.14	0.11	0.11
query13	0.61	0.61	0.60
query14	2.79	2.87	2.82
query15	0.90	0.83	0.82
query16	0.38	0.38	0.40
query17	1.05	1.07	1.08
query18	0.21	0.21	0.21
query19	1.98	1.89	2.01
query20	0.01	0.01	0.01
query21	15.40	0.59	0.59
query22	2.67	2.24	1.55
query23	17.22	0.97	0.93
query24	2.93	1.18	1.77
query25	0.20	0.12	0.07
query26	0.55	0.16	0.14
query27	0.04	0.04	0.04
query28	9.93	1.10	1.07
query29	12.58	3.22	3.24
query30	0.24	0.06	0.06
query31	2.89	0.38	0.38
query32	3.26	0.46	0.46
query33	3.02	3.00	3.24
query34	17.04	4.41	4.45
query35	4.55	4.46	4.51
query36	0.68	0.49	0.52
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.04	0.02	0.02
query40	0.18	0.14	0.13
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 106.64 s
Total hot run time: 32.81 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 5, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024

PR approved by anyone and no changes requested.

wangbo
wangbo approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@wangbo wangbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xinyiZzz xinyiZzz merged commit c1fea2d into apache:master Dec 5, 2024
github-actions bot pushed a commit that referenced this pull request Dec 5, 2024
@xinyiZzz
[fix](arrow-flight-sql) Fix query result is empty and not return quer…
29bd83b 
…y error message (#45023)

### What problem does this PR solve?

After the query failed, Doris Arrow Flight SQL returned an empty result
without returning the query error message.
@github-actions github-actions bot mentioned this pull request Dec 5, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Dec 5, 2024
@xinyiZzz
[fix](arrow-flight-sql) Fix query result is empty and not return quer…
cb9ec63 
…y error message (#45023)

### What problem does this PR solve?

After the query failed, Doris Arrow Flight SQL returned an empty result
without returning the query error message.
@github-actions github-actions bot mentioned this pull request Dec 5, 2024
Merged
yiguolei pushed a commit that referenced this pull request Dec 6, 2024
@github-actions @xinyiZzz
branch-2.1: [fix](arrow-flight-sql) Fix query result is empty and not…
a98cb8c 
… return query error message #45023 (#45053)

Cherry-picked from #45023

Co-authored-by: Xinyi Zou <zouxinyi@selectdb.com>
yiguolei pushed a commit that referenced this pull request Dec 6, 2024
@github-actions @xinyiZzz
branch-3.0: [fix](arrow-flight-sql) Fix query result is empty and not…
4f78c0c 
… return query error message #45023 (#45052)

Cherry-picked from #45023

Co-authored-by: Xinyi Zou <zouxinyi@selectdb.com>
@yiguolei yiguolei mentioned this pull request Jan 19, 2025
Closed
@gavinchou gavinchou mentioned this pull request Feb 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

@wangbo wangbo wangbo approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.4-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xinyiZzz @doris-robot @yiguolei @wangbo